[Webkit-unassigned] [Bug 203818] Proxy's [[OwnPropertyKeys]] is incorrect in DontEnumPropertiesMode::Exclude

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203818

--- Comment #7 from Alexey Shvayka <shvaikalesh at gmail.com> ---
(In reply to Keith Miller from comment #6)
> Comment on attachment 382961 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=382961&action=review
> 
> r=me with nit.
> 
> > Source/JavaScriptCore/runtime/ProxyObject.cpp:944
> > +    EnumerationMode enumerationMode(DontEnumPropertiesMode::Include);
> 
> Nit: It seems like we only use this in one place below. Can you just pass
> DontEnumPropertiesMode::Include to getOwnPropertyNames directly?

1. We also use `enumerationMode` in ProxyObject.cpp:1011 (invariants validation).
2. We also invoke `performGetOwnPropertyNames` in ProxyObject.cpp:1063 (we can't pass EnumerationMode there).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191120/d5b6f813/attachment.htm>