[Webkit-unassigned] [Bug 203818] Proxy's [[OwnPropertyKeys]] is incorrect in DontEnumPropertiesMode::Exclude

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203818

Keith Miller <keith_miller at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #382961|review?                     |review+
              Flags|                            |

--- Comment #6 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 382961
  --> https://bugs.webkit.org/attachment.cgi?id=382961
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382961&action=review

r=me with nit.

> Source/JavaScriptCore/runtime/ProxyObject.cpp:944
> +    EnumerationMode enumerationMode(DontEnumPropertiesMode::Include);

Nit: It seems like we only use this in one place below. Can you just pass DontEnumPropertiesMode::Include to getOwnPropertyNames directly?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191120/e3f3801a/attachment-0001.htm>