[Webkit-unassigned] [Bug 203898] Add FuzzerAgent that reads predictions from a file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 18 11:12:20 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=203898

--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 383545
  --> https://bugs.webkit.org/attachment.cgi?id=383545
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383545&action=review

>> Source/JavaScriptCore/runtime/PredictionFileCreatingFuzzerAgent.cpp:95
>> +        RELEASE_ASSERT_WITH_MESSAGE(false, "unhandled opcode: %s", toString(opcodeId).utf8().data());
> 
> why so few opcodes above?

never mind, these are just opcodes with heap predictions. Is still seems like we should just include all opcodes unconditionally since anytime someone adds a new opcode with a heap prediction, they'll need to fill in a case in this switch statement. However, we don't do anything special for different opcodes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191118/46d1f903/attachment.htm>


More information about the webkit-unassigned mailing list