[Webkit-unassigned] [Bug 203898] Add FuzzerAgent that reads predictions from a file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203898

--- Comment #10 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 383545
  --> https://bugs.webkit.org/attachment.cgi?id=383545
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383545&action=review

> Source/JavaScriptCore/runtime/FileBasedFuzzerAgent.cpp:79
> +        // FIXME: these can not be targeted at all due to the bugs below

style nit: indentation should be four spaces to the left

> Source/JavaScriptCore/runtime/FileBasedFuzzerAgent.cpp:85
> +        // FIXME: the output of codeBlock->expressionRangeForBytecodeIndex() allows for some of
> +        // these opcodes to have predictions, but not all instances can be reliably targeted.

style nit: indentation should be four spaces to the left

> Source/JavaScriptCore/runtime/FuzzerPredictions.cpp:49
> +        size_t length = strlen(line);
> +        if (line[length - 1] == '\n') {
> +            line[length - 1] = '\0';
> +            length--;
> +        }

this processing might be nicer if you just read the entire file into a WTF string, which has a split function

> Source/JavaScriptCore/runtime/PredictionFileCreatingFuzzerAgent.cpp:95
> +    default:
> +        RELEASE_ASSERT_WITH_MESSAGE(false, "unhandled opcode: %s", toString(opcodeId).utf8().data());

why so few opcodes above?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191118/702c2fbc/attachment-0001.htm>