[Webkit-unassigned] [Bug 139681] Touch support is reported even when the device doesn't have a touch screen

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 23 08:19:16 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=139681

--- Comment #26 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #25)
> Comment on attachment 370502 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=370502&action=review
> 
> > Source/WebCore/page/RuntimeEnabledFeatures.h:536
> > +    Optional<bool> m_touchEventsEnabled;
> 
> This seems confusing. The semantics of Optional don't lead themselves to a
> natural interpretation of this member variable. What does it mean for
> m_touchEventsEnabled to be unset: neither enabled nor disabled?

When not explicitly set PlatformScreen is queried for touch capabilities.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190523/8c8eefcc/attachment-0001.html>


More information about the webkit-unassigned mailing list