[Webkit-unassigned] [Bug 139681] Touch support is reported even when the device doesn't have a touch screen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139681

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370502|review?                     |review+
              Flags|                            |

--- Comment #25 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 370502
  --> https://bugs.webkit.org/attachment.cgi?id=370502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370502&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.h:536
> +    Optional<bool> m_touchEventsEnabled;

This seems confusing. The semantics of Optional don't lead themselves to a natural interpretation of this member variable. What does it mean for m_touchEventsEnabled to be unset: neither enabled nor disabled?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190523/b74072ab/attachment.html>