[Webkit-unassigned] [Bug 195225] Check whether to launch a default action instead of action sheet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195225

--- Comment #24 from Daniel Bates <dbates at webkit.org> ---
(In reply to Jennifer Moore from comment #21)
> (In reply to Daniel Bates from comment #19)
> > Comment on attachment 363942 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=363942&action=review
> > 
> > The refactoring is bad in my opinion and makes things worse. I think the
> > right refactoring is everything except the target URL computation. Haven’t
> > thought it through but I would rather take the duplication then this refactor
> > 
> > > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:-564
> > > -    auto delegate = _delegate.get();
> > 
> > This looks like a bad refactor. Should check delegate in this function too.
> > 
> > > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:604
> > > +        || !WebCore::DataDetection::canBePresentedByDataDetectors(targetURL)) return;
> > 
> > Formatting doesn’t look right. Grep code for examples or read style guide
> 
> This formatting was required by the upload script

Don't know what upload script you are referring to, maybe webkit-patch (which calls check-webkit-style) <--- though no way check-webkit-style would suggest putting return on same line. Well, it must have based on your facts. That's a terrible bug. Anyway, the answer is this code is wrongly formatter. Read code style guide.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190308/8c61c1e5/attachment.html>