[Webkit-unassigned] [Bug 195225] Check whether to launch a default action instead of action sheet

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 16:05:00 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=195225

--- Comment #23 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 363944
  --> https://bugs.webkit.org/attachment.cgi?id=363944
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363944&action=review

>> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:187
>> +    _WKElementAction *elementAction = [_WKElementAction elementActionWithTitle:action.localizedName actionHandler:^(_WKActivatedElementInfo *actionInfo) {
> 
> Auto? And right-hand-side should be wrapped in adoptNS()

Eh, no need for adoptNS(). should use auto* (not auto)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190308/146a722e/attachment.html>


More information about the webkit-unassigned mailing list