[Webkit-unassigned] [Bug 198995] [GTK] Enable navigation swipe layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 20 07:49:27 PDT 2019


--- Comment #13 from Alexander Mikhaylenko <exalm7659 at gmail.com> ---
(In reply to Michael Catanzaro from comment #12)
> Better/clearer:
> event->scroll.window = g_object_ref(window);

Needs an additional cast. :)

../../Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp: In function ‘WTF::GUniquePtr<_GdkEvent> WebKit::createScrollEvent(GtkWidget*, double, double)’:
../../Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:423:40: error: invalid conversion from ‘gpointer’ {aka ‘void*’} to ‘GdkWindow*’ {aka ‘_GdkWindow*’} [-fpermissive]
     event->scroll.window = g_object_ref(window);

    event->scroll.window = reinterpret_cast<GdkWindow*>(g_object_ref(window));
is still fine (honestly, looks less clean to me), then sure. :)

> This should be lower in the expectations file under the flaky section, since
> it's a failure that should be fixed, rather than a failure that we're OK
> with having forever like the other test you've added here.


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190620/03fd3e83/attachment.html>

More information about the webkit-unassigned mailing list