[Webkit-unassigned] [Bug 198995] [GTK] Enable navigation swipe layout tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198995

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372547|review?                     |review+
              Flags|                            |

--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372547
  --> https://bugs.webkit.org/attachment.cgi?id=372547
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372547&action=review

LGTM

> Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:424
> +    g_object_ref(window);
> +    event->scroll.window = window;

Better/clearer:

event->scroll.window = g_object_ref(window);

> LayoutTests/platform/gtk/TestExpectations:1228
> +# Flaky, the order of lines in the output may change.
> +webkit.org/b/170484 swipe/main-frame-pinning-requirement.html [ Pass Failure ]

This should be lower in the expectations file under the flaky section, since it's a failure that should be fixed, rather than a failure that we're OK with having forever like the other test you've added here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190620/a7309b5d/attachment-0001.html>