[Webkit-unassigned] [Bug 200003] New pages don't account for device orientation.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 22 11:59:28 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=200003
Tim Horton <thorton at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |thorton at apple.com
Attachment #374607|1 |0
is obsolete| |
--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 374607
--> https://bugs.webkit.org/attachment.cgi?id=374607
Save viewport size in dynamicViewportSizeUpdate
View in context: https://bugs.webkit.org/attachment.cgi?id=374607&action=review
> Source/WebKit/ChangeLog:3
> + New pages don't account for device orientation.
"deviceOrientation" is one of the /other/ parameters to dynamicViewportSizeUpdate, so this title is quite confusing; this is really about the layout size
> Source/WebKit/ChangeLog:13
> + Moreover, in WKWebView there is lastSentViewLayoutSize property, which is used to not update viewport size
> + if it is not changed. So, it is blocking new updates to pass to
_lastSentViewLayoutSize is reset upon process swap or crash, so I don't quite get this part
> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:298
> + m_viewportConfigurationViewLayoutSize = viewLayoutSize;
It seems surprising that we'd only need to save one of the parameters (what happens to e.g. maximumUnobscuredSize?). I wonder if it's missing from elsewhere instead of needing to be added here?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190722/070d9965/attachment.html>
More information about the webkit-unassigned
mailing list