[Webkit-unassigned] [Bug 199377] [WPE] Draw other button types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199377

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 373259
  --> https://bugs.webkit.org/attachment.cgi?id=373259
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373259&action=review

>> Source/WebCore/platform/wpe/ThemeWPE.cpp:71
>> +    case ButtonPart:
> 
> Please use fallthrough annotations:
> 
> case DefaultButtonPart:
>     FALLTHROUGH;
> case ButtonPart:
>     FALLTHROUGH;
> case SquareButtonPart:

I don't think we want FALLTHROUGH in those cases, because it's obvious. FALLTHROUGH is useful when you actually have code in the case and want to fallthrough to the next case, to make it explicit that you haven't forgotten the break.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190716/3b30e429/attachment.html>