[Webkit-unassigned] [Bug 199377] [WPE] Draw other button types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=199377

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373259
  --> https://bugs.webkit.org/attachment.cgi?id=373259
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373259&action=review

Could you please add a ChangeLog entry (Tools/Scripts/prepare-ChangeLog -b 199377)?

Then the ChangeLog can explain more directly why you're changing what you're changing here.

> Source/WebCore/platform/wpe/ThemeWPE.cpp:71
> +    case DefaultButtonPart:
> +    case ButtonPart:

Please use fallthrough annotations:

case DefaultButtonPart:
    FALLTHROUGH;
case ButtonPart:
    FALLTHROUGH;
case SquareButtonPart:

> Source/WebCore/platform/wpe/ThemeWPE.cpp:142
> +    float roundness = 2;
> +
> +    if (part == SquareButtonPart)
> +        roundness = 0;

It'd be nicer to write this in one line IMO:

float roundness = (part == SquareButtonPart) ? 0 : 2;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190716/2fd0de57/attachment.html>