[Webkit-unassigned] [Bug 191498] [Curl] implement CertificateInfo::summaryInfo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 10 19:28:16 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=191498

--- Comment #15 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #9)
> Comment on attachment 373699 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373699&action=review
> 
> > Source/WebCore/platform/network/curl/CertificateInfo.h:102
> > +            WebCore::CertificateInfo::Certificate certificate(certSize);
> 
> Before allocating the buffer certificate, you should check the decoder
> remaining data size.
> decoder.bufferIsLargeEnoughToContain<char>(certSize)
> You can see other decoder example by grepping "bufferIsLargeEnoughToContain".

decoder.decode() and decoder.decodeFixedLengthData() call bufferIsLargeEnoughToContain internally.
Do we have to call that before allocating Certificate again?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190711/1756ebe2/attachment.html>


More information about the webkit-unassigned mailing list