[Webkit-unassigned] [Bug 191498] [Curl] implement CertificateInfo::summaryInfo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191498

--- Comment #14 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #8)
> Comment on attachment 373699 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373699&action=review
> 
> >> Source/WebCore/platform/network/curl/CertificateInfo.h:76
> >> +        auto certificateChain = certificateInfo.certificateChain();
> > 
> > This is a common C++ pit-hole. The type of certificateInfo.certificateChain() is "const Vector<Certificate>&", but type of auto drops & and "const Vector<Certificate>".
> > Then, this sentence copies the Vector.
> > auto& certificateChain = certificateInfo.certificateChain();
> 
> Not copying, but just ref-ing. However we should avoid such unnecessary
> ref-ing.

Changed to auto&.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190711/938a3152/attachment-0001.html>