[Webkit-unassigned] [Bug 199559] [GStreamer] Ensure that “volume = foo; assert(volume == foo)” always succeeds

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 10 08:42:41 PDT 2019


--- Comment #5 from Charlie Turner <cturner at igalia.com> ---
(In reply to Philippe Normand from comment #3)
> In MediaPlayerPrivateGStreamerBase::notifyPlayerOfVolumeChange() why do we
> cast the value to float? m_player->volumeChanged() expects a double.

It's old code, perhaps the MediaPlayer class changed since it was written. Regardless, it doesn't matter since the error from PA has already crept in before we start casting. Same goes for the setVolumeDouble, PA behavior still introduces this issue.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190710/43de9597/attachment.html>

More information about the webkit-unassigned mailing list