[Webkit-unassigned] [Bug 198269] Implement MappedFileData for Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198269

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #373420|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 373420
  --> https://bugs.webkit.org/attachment.cgi?id=373420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373420&action=review

> Source/WTF/wtf/FileSystem.cpp:277
> +#if HAVE(MMAP)

Should have a blank line after this.

> Source/WTF/wtf/FileSystem.cpp:326
> +#endif

Should have a blank line before this.

> Source/WTF/wtf/FileSystem.h:36
> +#include <wtf/Noncopyable.h>

See comment below.

> Source/WTF/wtf/FileSystem.h:196
> +    WTF_MAKE_NONCOPYABLE(MappedFileData);

Given my understanding of C++, this should not be necessary. Defining a move constructor and a move assignment operator as this class does should implicitly cause the copy constructor and copy assignment operator to not be generated. So there should be no additional need to use WTF_MAKE_NOCOPYABLE.

Was there some concrete problem that this fixed on Windows? Maybe my understanding of C++ is wrong, or maybe this works around a bug in the Windows C++ compiler.

I’d prefer to not make the change unless it’s required.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190703/6d5615a4/attachment.html>