[Webkit-unassigned] [Bug 198269] Implement MappedFileData for Windows
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 3 15:15:05 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=198269
Christopher Reid <chris.reid at sony.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris.reid at sony.com
Attachment #373420| |review?
Flags| |
--- Comment #2 from Christopher Reid <chris.reid at sony.com> ---
Created attachment 373420
--> https://bugs.webkit.org/attachment.cgi?id=373420&action=review
Patch
It looks like the only FileSystem Mapping test that was failing was MappingExistingEmptyFile but it passes after adding the `if (!size) {` check from the mmap implementation.
I also moved the mmap implementation back to FileSystem.cpp from FileSystemPOSIX. It would be nice to split it up to posix and glib implementations.
The only FileSystem tests failing on windows now are FileSystemTest.UnicodeDirectoryName and FileSystemTest.GetFileMetadataSymlink.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190703/44b1f134/attachment-0001.html>
More information about the webkit-unassigned
mailing list