[Webkit-unassigned] [Bug 194086] [GLIB] WebDriver: race condition when session starts

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 04:49:27 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=194086

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Philippe Normand from comment #2)
> Comment on attachment 360716 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360716&action=review
> 
> > Source/WebDriver/glib/SessionHostGlib.cpp:335
> >          m_connectionID = 0;
> > -        if (m_dbusConnection)
> > +        if (m_connectionID && m_dbusConnection)
> 
> So now this condition is always false because m_connectionID is set to 0
> before the if. Is this correct? Why not remove the if block then?

Oops, you are right!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190131/c95d6b58/attachment.html>


More information about the webkit-unassigned mailing list