[Webkit-unassigned] [Bug 194086] [GLIB] WebDriver: race condition when session starts

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 04:17:32 PST 2019


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |pnormand at igalia.com
 Attachment #360716|review+                     |review?
              Flags|                            |

--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 360716
  --> https://bugs.webkit.org/attachment.cgi?id=360716

View in context: https://bugs.webkit.org/attachment.cgi?id=360716&action=review

> Source/WebDriver/glib/SessionHostGlib.cpp:335
>          m_connectionID = 0;
> -        if (m_dbusConnection)
> +        if (m_connectionID && m_dbusConnection)

So now this condition is always false because m_connectionID is set to 0 before the if. Is this correct? Why not remove the if block then?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190131/f5d82080/attachment.html>

More information about the webkit-unassigned mailing list