[Webkit-unassigned] [Bug 193665] [iOS] Tiles not created in large scrollable iframes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 11:44:26 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=193665

--- Comment #12 from Antti Koivisto <koivisto at iki.fi> ---
> Do we understand the history here, and why your removal doesn't break
> something?

Nothing is really removed here scrollContainerLayer just also serves as insetClipLayer. All the logic around that is unchanged.

> The "that moves" is confusing. How does this layer move its content? The
> moving is done by setting bounds origin or position on m_scrollLayer, right?
> This layer doesn't control that.

Yeah, bad comment.

> > Source/WebCore/rendering/RenderLayerCompositor.h:566
> > +    // Layer that moves during scrolling.
> >      RefPtr<GraphicsLayer> m_scrollLayer;
> 
> Can we call this scrolledContentsLayer? That would be more consistent with
> RenderLayerBacking names.

There is existing scrolledContentsLayer in scrolling tree though, which does not map to this layer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190130/7071c51a/attachment.html>


More information about the webkit-unassigned mailing list