[Webkit-unassigned] [Bug 193665] [iOS] Tiles not created in large scrollable iframes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 11:26:11 PST 2019


--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 360596
  --> https://bugs.webkit.org/attachment.cgi?id=360596

View in context: https://bugs.webkit.org/attachment.cgi?id=360596&action=review

> Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h:-109
> -    // This is a clipping layer that will scroll with the page for all y-delta scroll values between 0
> -    // and topContentInset(). Once the y-deltas get beyond the content inset point, this layer no longer
> -    // needs to move. If the topContentInset() is 0, this layer does not need to move at all. This is
> -    // only used on the Mac.

Do we understand the history here, and why your removal doesn't break something?

> Source/WebCore/rendering/RenderLayerCompositor.h:564
> +    // Layer that moves and clips its content layer.
> +    RefPtr<GraphicsLayer> m_scrollContainerLayer;

The "that moves" is confusing. How does this layer move its content? The moving is done by setting bounds origin or position on m_scrollLayer, right? This layer doesn't control that.

> Source/WebCore/rendering/RenderLayerCompositor.h:566
> +    // Layer that moves during scrolling.
>      RefPtr<GraphicsLayer> m_scrollLayer;

Can we call this scrolledContentsLayer? That would be more consistent with RenderLayerBacking names.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190130/be1d1d3e/attachment.html>

More information about the webkit-unassigned mailing list