[Webkit-unassigned] [Bug 193816] [Curl] Fix DRT crash related to private browsing.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193816

--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 360574
  --> https://bugs.webkit.org/attachment.cgi?id=360574
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360574&action=review

Looks good to me.

> Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp:111
> +    auto addResult = globalSessionMap().add(sessionID, nullptr);

You could use HashMap::ensure here.

> Source/WebKitLegacy/win/WebCoreSupport/WebFrameNetworkingContext.cpp:91
> +    if (auto privateSession = NetworkStorageSessionMap::storageSession(PAL::SessionID::legacyPrivateSessionID()))
> +        return *privateSession;

This seems unnecessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190130/192065f5/attachment.html>