[Webkit-unassigned] [Bug 193816] [Curl] Fix DRT crash related to private browsing.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193816

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #360574|review?                     |review+
              Flags|                            |

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 360574
  --> https://bugs.webkit.org/attachment.cgi?id=360574
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360574&action=review

> Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp:115
> +    addResult.iterator->value = std::make_unique<WebCore::NetworkStorageSession>(sessionID, nullptr);

Unrelated: I think you should remove the second parameter from your NetworkStorageSession constructor. It's a curl-specific constructor, and I believe you have to always pass nullptr for it to not crash. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190130/a335d459/attachment-0001.html>