[Webkit-unassigned] [Bug 192030] Layout test should generate performance metrics

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 8 09:46:46 PST 2019


--- Comment #25 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 358550
  --> https://bugs.webkit.org/attachment.cgi?id=358550

View in context: https://bugs.webkit.org/attachment.cgi?id=358550&action=review

r=me assuming Dean Johnson's in-person feedback has been incorporated.

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:122
> +def _add_test_perf_metric(path, time, tests, depth, target_depth):

Ditto. _add_perf_metric_for_test() might read better.

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:159
> +def test_perf_metrics(run_time, individual_test_timings):

'test_perf_metrics' name feels like this is a test for perf_metrics. perf_metrics_for_test might read better.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190108/5e298707/attachment.html>

More information about the webkit-unassigned mailing list