[Webkit-unassigned] [Bug 193665] [iOS] Tiles not created in large scrollable iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193665

--- Comment #23 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 361020
  --> https://bugs.webkit.org/attachment.cgi?id=361020
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361020&action=review

>> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:473
>> +void AsyncScrollingCoordinator::setScrollPositionToScrollingLayer(FrameView& frameView)
> 
> setScrollPositionForScrollingLayer? Setting the position "to" a layer doesn't make sense. Also we're trying to avoid the term "scrolling layer".
> 
> For overflow, I implemented this equivalent in RenderLayerBacking::setLocationOfScrolledContents(ScrollOffset scrollOffset, ScrollingLayerPositionAction setOrSync). Maybe this code should live in RenderLayerCompositor?
> 
> Another option is to give the ScrollingStateTreeNodes this responsibility.

I combined the set/sync functions and just called it reconcileScrollPosition. Maybe the shared function should be a static function hanging from say GraphicsLayer and taking both the container and contents layers as parameters?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190204/bf8ff354/attachment-0001.html>