[Webkit-unassigned] [Bug 205460] Update TrackBase to store m_mediaElement as a WeakPtr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205460

--- Comment #14 from Darin Adler <darin at apple.com> ---
(In reply to Chris Dumez from comment #13)
> My opinions is that methods should take an an HTMLMediaElement& or a
> HTMLMediaElement* in parameter. Then, here when saving it as a data member,
> we would call makeWeakPtr().
> It should be up to the class that store the data to decide which pointer
> type to use for storage, not the call site IMHO.

I agree.

With one outstanding question:

How does that relate to Ryosuke's proposal to always use RefPtr and Ref for local variables from now on instead of raw pointers and references? Aren't arguments just local variables?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191220/9abaea32/attachment.htm>