[Webkit-unassigned] [Bug 205460] Update TrackBase to store m_mediaElement as a WeakPtr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205460

--- Comment #13 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 386241
  --> https://bugs.webkit.org/attachment.cgi?id=386241
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386241&action=review

> Source/WebCore/html/track/TrackListBase.cpp:44
> +    , m_element(WTFMove(element))

My opinions is that methods should take an an HTMLMediaElement& or a HTMLMediaElement* in parameter. Then, here when saving it as a data member, we would call makeWeakPtr().
It should be up to the class that store the data to decide which pointer type to use for storage, not the call site IMHO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191220/d1351184/attachment-0001.htm>