[Webkit-unassigned] [Bug 204754] Add exclusion rule for text manipulation SPI to exclude based on element class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204754

--- Comment #8 from Louie Livon-Bemel <llivonbemel at apple.com> ---
(In reply to Louie Livon-Bemel from comment #7)
> (In reply to Wenson Hsieh from comment #5)
> > Comment on attachment 384723 [details]
> > 57398802-part-2.patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=384723&action=review
> > 
> > > Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:283
> > > +        [[[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES forAttribute:@"data-exclude" value:@"yes"] autorelease],
> > > +        [[[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)NO forAttribute:@"data-exclude" value:@"no"] autorelease],
> > > +        [[[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES forClass:@"exclude"] autorelease],
> > 
> > Nit - I don’t think you need the (BOOL) casts here.
> 
> At one point I had a build issue where it didn't understand these values,
> and a typecast fixed it. I'll see if these are still required.

Testing this now, I see no issues when removing the typecast. It looks like the tests Ryosuke originally added include the typecast so that's probably why I did too. I'll remove them from my tests though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191204/d9a4fe28/attachment-0001.htm>