[Webkit-unassigned] [Bug 204754] Add exclusion rule for text manipulation SPI to exclude based on element class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 4 09:13:20 PST 2019


--- Comment #7 from Louie Livon-Bemel <llivonbemel at apple.com> ---
(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 384723 [details]
> 57398802-part-2.patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384723&action=review
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:283
> > +        [[[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES forAttribute:@"data-exclude" value:@"yes"] autorelease],
> > +        [[[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)NO forAttribute:@"data-exclude" value:@"no"] autorelease],
> > +        [[[_WKTextManipulationExclusionRule alloc] initExclusion:(BOOL)YES forClass:@"exclude"] autorelease],
> Nit - I don’t think you need the (BOOL) casts here.

At one point I had a build issue where it didn't understand these values, and a typecast fixed it. I'll see if these are still required.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191204/f114edd3/attachment.htm>

More information about the webkit-unassigned mailing list