[Webkit-unassigned] [Bug 197148] [aarch64] clang Wc++11-narrowing for unsigned char in WebCore/contentextensions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197148

--- Comment #1 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 367910
  --> https://bugs.webkit.org/attachment.cgi?id=367910
webkit-schar.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367910&action=review

> Source/WebCore/contentextensions/DFACombiner.cpp:40
> +    typedef MutableRangeList<signed char, uint64_t, 128> CombinedTransitionsMutableRangeList;

WebKit coding style is to use one word (signed/unsigned, not signed char/unsigned char).

I don't know if we necessarily want to fix this warning in code, it looks overly pedantic. But to have this discussed, it will be useful to formally post it for review (with a ChangeLog, and marked r?). Would you be willing to do that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190422/f465fc0e/attachment.html>