[Webkit-unassigned] [Bug 197148] New: [aarch64] clang Wc++11-narrowing for unsigned char in WebCore/contentextensions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197148

            Bug ID: 197148
           Summary: [aarch64] clang Wc++11-narrowing for unsigned char in
                    WebCore/contentextensions
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Other
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: wk at unrelenting.technology

Created attachment 367910

  --> https://bugs.webkit.org/attachment.cgi?id=367910&action=review

webkit-schar.patch

Building WebKitGtk+ 2.24.0 on FreeBSD/aarch64 (13-CURRENT) results in signed char warnings (that get turned into errors by Werror):

http://thunderx1.nyi.freebsd.org/data/head-arm64-default/p498440_s346039/logs/errors/webkit2-gtk3-2.24.0_1.log

/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.24.0/Source/WebCore/contentextensions/DFACombiner.cpp:109:52: error: non-constant-expression cannot be narrowed from type 'char' to 'signed char' in initializer list [-Wc++11-narrowing]
                m_output.transitionRanges.append({ range.first, range.last });
                                                   ^~~~~~~~~~~
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.24.0/Source/WebCore/contentextensions/DFACombiner.cpp:109:52: note: insert an explicit cast to silence this issue
                m_output.transitionRanges.append({ range.first, range.last });
                                                   ^~~~~~~~~~~
                                                   static_cast<signed char>( )
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.24.0/Source/WebCore/contentextensions/DFACombiner.cpp:109:65: error: non-constant-expression cannot be narrowed from type 'char' to 'signed char' in initializer list [-Wc++11-narrowing]
                m_output.transitionRanges.append({ range.first, range.last });
                                                                ^~~~~~~~~~
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.24.0/Source/WebCore/contentextensions/DFACombiner.cpp:109:65: note: insert an explicit cast to silence this issue
                m_output.transitionRanges.append({ range.first, range.last });
                                                                ^~~~~~~~~~
                                                                static_cast<signed char>( )

The attached patch fixes this by using signed chars in the types of the 'range' objects.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190421/56c71244/attachment.html>