[Webkit-unassigned] [Bug 196622] [WinCairo] Move to Visual Studio 2019

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196622

--- Comment #23 from Fujii Hironori <Hironori.Fujii at sony.com> ---
(In reply to Stephan Szabo from comment #22)
> I can't tell if you're suggesting removing all the fallbacks for when vcvars
> wasn't run (for example VSINSTALLDIR is not set). 
> If you aren't then we still have to deal with those cases somehow.

We shouldn't remove the fallback. build-webkit should choose the latest installed VS as the fallback.
I'm not sure which is better to choose the latest VS by using vswhere or using CMake (I think CMake can find the latest installed VS. Right?).

> In either case, it seems like current cmake (3.14) uses the generator
> version as input to how at least some of the code paths choose a Visual
> Studio instance, so it's unclear to me that leaving the script using the
> 2017 generator while having both 2017 and 2019 installed will have the
> desired behavior.

Good point. I'll check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190406/1ecf9290/attachment.html>