[Webkit-unassigned] [Bug 196622] [WinCairo] Move to Visual Studio 2019

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196622

--- Comment #22 from Stephan Szabo <stephan.szabo at sony.com> ---
(In reply to Fujii Hironori from comment #21)
> (In reply to Stephan Szabo from comment #17)
> 
> > E) And we would like to make it easy to be able to switch between ports
> > without requiring the user the also switch between shells.
> 
> I’m against (E).
> I’m suggesting invoking vcvars in outside of build-WebKit to choose compiler.

I can't tell if you're suggesting removing all the fallbacks for when vcvars wasn't run (for example VSINSTALLDIR is not set). 

If you aren't then we still have to deal with those cases somehow.

If you are suggesting removing the fallbacks, that seems to change a long standing behavior of the scripts as I see those going back at least 6 years to VS8.

In either case, it seems like current cmake (3.14) uses the generator version as input to how at least some of the code paths choose a Visual Studio instance, so it's unclear to me that leaving the script using the 2017 generator while having both 2017 and 2019 installed will have the desired behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190406/93256057/attachment.html>