[Webkit-unassigned] [Bug 193073] [JSC] Lots of missing #include's when building with -DENABLE_UNIFIED_BUILDS=OFF

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 5 15:54:05 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=193073

Ross Kirsling <ross.kirsling at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |keith_miller at apple.com,
                   |                            |ross.kirsling at sony.com,
                   |                            |stephan.szabo at sony.com

--- Comment #7 from Ross Kirsling <ross.kirsling at sony.com> ---
Looks like the linking errors are mostly due to the following:

1. <path>/a.h:   templated method is declared
2. <path>/a.cpp: templated method is defined and called with template param Foo
3. <path>/b.cpp: templated method is called with template param Bar

Which happens to work when unified sources are enabled because the implementation files are adjacent. 

Steph on our team noticed that technically one could add the following line after the method definition in a.cpp: 

>  template ... SomeClass::someMethod<Bar>(...);
But I'm assuming this would be less desirable than transplanting the definition to a more appropriate location. :P

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190405/7d676a6f/attachment.html>


More information about the webkit-unassigned mailing list