[Webkit-unassigned] [Bug 193073] [JSC] Lots of missing #include's when building with -DENABLE_UNIFIED_BUILDS=OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193073

--- Comment #8 from Ross Kirsling <ross.kirsling at sony.com> ---
Now, ALWAYS_INLINE seems to be of no use, but for something like...
> LocalAllocator.cpp.obj : error LNK2019: unresolved external symbol "public: class JSC::HeapCell * __cdecl JSC::FreeList::allocate<class <lambda_8437a926922bdf66125377eabab8b83d> >(class <lambda_8437a926922bdf66125377eabab8b83d> const &)" (??$allocate at V<lambda_8437a926922bdf66125377eabab8b83d>@@@FreeList at JSC@@QEAAPEAVHeapCell at 1@AEBV<lambda_8437a926922bdf66125377eabab8b83d>@@@Z) referenced in function "private: void * __cdecl JSC::LocalAllocator::tryAllocateIn(class JSC::MarkedBlock::Handle *)" (?tryAllocateIn at LocalAllocator@JSC@@AEAAPEAXPEAVHandle at MarkedBlock@2@@Z)
...we could just move the definition to the declaration site:
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/heap/FreeListInlines.h#L33-L50
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/heap/FreeList.h#L72-L73

But this gets kind of out of hand for something like...
> JITOperations.cpp.obj : error LNK2019: unresolved external symbol "private: void __cdecl JSC::JIT::privateCompilePutByVal<struct JSC::OpPutByVal>(class JSC::ConcurrentJSLocker const &,struct JSC::ByValInfo *,class JSC::ReturnAddressPtr,enum JSC::JITArrayMode)" (??$privateCompilePutByVal at UOpPutByVal@JSC@@@JIT at JSC@@AEAAXAEBVConcurrentJSLocker at 1@PEAUByValInfo at 1@VReturnAddressPtr at 1@W4JITArrayMode at 1@@Z) referenced in function "public: static void __cdecl JSC::JIT::compilePutByVal(class JSC::ConcurrentJSLocker const &,class JSC::VM *,class JSC::CodeBlock *,struct JSC::ByValInfo *,class JSC::ReturnAddressPtr,enum JSC::JITArrayMode)" (?compilePutByVal at JIT@JSC@@SAXAEBVConcurrentJSLocker at 2@PEAVVM at 2@PEAVCodeBlock at 2@PEAUByValInfo at 2@VReturnAddressPtr at 2@W4JITArrayMode at 2@@Z)
...in which case moving privateCompilePutByVal from JITPropertyAccess.cpp to JIT.h leads to a pretty severe domino effect. :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190405/c0bb9848/attachment.html>