[Webkit-unassigned] [Bug 181228] Web Inspector: [GTK] Copy copies to nowhere

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=181228

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #366482|review?                     |review+
              Flags|                            |

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 366482
  --> https://bugs.webkit.org/attachment.cgi?id=366482
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366482&action=review

> Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp:158
> +        case ActionType:
> +        case CheckableActionType: {

Is there no complaint from -Wimplicit-fallthrough? We have a FALLTHROUGH macro that expands to a suitable attribute to avoid warnings here:

case ActionType:
    FALLTHROUGH;
case CheckableActionType: {

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190402/842a43e6/attachment.html>