[Webkit-unassigned] [Bug 181228] Web Inspector: [GTK] Copy copies to nowhere

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=181228

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joepeck at webkit.org

--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 366482
  --> https://bugs.webkit.org/attachment.cgi?id=366482
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366482&action=review

>> Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp:158
>> +        case CheckableActionType: {
> 
> Is there no complaint from -Wimplicit-fallthrough? We have a FALLTHROUGH macro that expands to a suitable attribute to avoid warnings here:
> 
> case ActionType:
>     FALLTHROUGH;
> case CheckableActionType: {

FALLTHROUGH is normally only necessary if there has been some statement between case statements. Here they are grouped directly next to each other so it probably won't be necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190402/9c58f1a2/attachment.html>