[Webkit-unassigned] [Bug 156674] Build tools should work when the /usr/bin/python is python3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156674

--- Comment #29 from Mike Gorse <mgorse at suse.com> ---
(In reply to Michael Catanzaro from comment #28)
> Comment on attachment 350303 [details]
> Updated patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=350303&action=review
> 
> OK, thanks!
> 
> The try/except imports are a bit yucky, but I guess that's what we're stuck
> with if we have XCode doing something different than CMake.
> 
> > Source/JavaScriptCore/Scripts/wkbuiltins/builtins_model.py:159
> > +    def __lt__(self, other):
> > +        return self.function_name < other.function_name
> 
> Why is it needed?

I added that in order to get sort to work on python 3. http://python3porting.com/problems.html#comparisons

> > Source/JavaScriptCore/Scripts/wkbuiltins/builtins_model.py:309
> > +        return list(map(BuiltinFunction.fromString, functionStrings))
> 
> You've done this in a couple other places. Why do you need to wrap the map
> in a list?

Map returns an iterator in python 3, not a list as in python 2. Those lines were changed automatically when I ran 2to3, though, so it's possible that the wrapping isn't needed in every place where I have it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180921/0dd8567e/attachment-0001.html>