[Webkit-unassigned] [Bug 156674] Build tools should work when the /usr/bin/python is python3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156674

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #350303|review?                     |review+
              Flags|                            |

--- Comment #28 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 350303
  --> https://bugs.webkit.org/attachment.cgi?id=350303
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=350303&action=review

OK, thanks!

The try/except imports are a bit yucky, but I guess that's what we're stuck with if we have XCode doing something different than CMake.

> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_model.py:159
> +    def __lt__(self, other):
> +        return self.function_name < other.function_name

Why is it needed?

> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_model.py:309
> +        return list(map(BuiltinFunction.fromString, functionStrings))

You've done this in a couple other places. Why do you need to wrap the map in a list?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180921/4ef4cdd3/attachment.html>