[Webkit-unassigned] [Bug 188772] Allow override of viewport configuration

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 17:30:30 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=188772

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #349638|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349638
  --> https://bugs.webkit.org/attachment.cgi?id=349638
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349638&action=review

> LayoutTests/ChangeLog:15
> +        * fast/viewport/ios/ipad/baseline.html: Added.

baseline.html is a confusing name. Maybe just no-viewport.html.

> LayoutTests/ChangeLog:17
> +        * fast/viewport/ios/ipad/meta-viewport-disabled.html: Added.

I would not use  -disabled in a test name; it's too easily confused with the test being disabled. Call it meta-viewport-ignored.html.

> LayoutTests/fast/viewport/ios/ipad/baseline.html:5
> +    <meta name="viewport" content="">

Is this equivalent to no viewport tag at all?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180914/86e67e93/attachment.html>


More information about the webkit-unassigned mailing list