[Webkit-unassigned] [Bug 188772] Allow override of viewport configuration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188772

--- Comment #13 from James Savage <james.savage at apple.com> ---
Comment on attachment 349638
  --> https://bugs.webkit.org/attachment.cgi?id=349638
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349638&action=review

>> LayoutTests/ChangeLog:15
>> +        * fast/viewport/ios/ipad/baseline.html: Added.
> 
> baseline.html is a confusing name. Maybe just no-viewport.html.

Will change.

>> LayoutTests/ChangeLog:17
>> +        * fast/viewport/ios/ipad/meta-viewport-disabled.html: Added.
> 
> I would not use  -disabled in a test name; it's too easily confused with the test being disabled. Call it meta-viewport-ignored.html.

Will change.

>> LayoutTests/fast/viewport/ios/ipad/baseline.html:5
>> +    <meta name="viewport" content="">
> 
> Is this equivalent to no viewport tag at all?

As best I can tell yes. I chose this route to avoid updating the test javascript, which makes the assumption that there will be a viewport tag and hits an exception if there is not. But if you’d rather I can patch the JS to deal with no meta tag rather than doing this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180914/5d271868/attachment.html>