[Webkit-unassigned] [Bug 188996] Add IGNORE_WARNING_.* macros

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188996

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #349427|review?                     |review+
              Flags|                            |

--- Comment #47 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 349427
  --> https://bugs.webkit.org/attachment.cgi?id=349427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349427&action=review

I haven't reviewed every use of the macros, but the sampling of the changes I looked at seem good, and the macros themselves look good too, and have been extensively discussed here. I like! r=me

> Source/WTF/wtf/Compiler.h:452
> +#if !defined(ALLOW_DEPRECATED_DECLARATIONS_BEGIN)
> +#define ALLOW_DEPRECATED_DECLARATIONS_BEGIN IGNORE_WARNINGS_BEGIN("deprecated-declarations")
> +#define ALLOW_DEPRECATED_DECLARATIONS_END IGNORE_WARNINGS_END
> +#endif

Please get rid of all the #if !defined() checks here too. They're not useful and just clutter the file. Nobody is going to be redefining these ever.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180911/38da7dc4/attachment.html>