[Webkit-unassigned] [Bug 188996] Add IGNORE_WARNING_.* macros

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 17:24:49 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=188996

--- Comment #48 from Darin Adler <darin at apple.com> ---
Comment on attachment 349427
  --> https://bugs.webkit.org/attachment.cgi?id=349427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349427&action=review

> Source/WebKitLegacy/mac/History/WebHistory.h:134
> -#pragma clang diagnostic push
> -#pragma clang diagnostic ignored "-Wdeprecated-declarations"
> +ALLOW_DEPRECATED_DECLARATIONS_BEGIN
>  - (NSArray *)orderedItemsLastVisitedOnDay:(NSCalendarDate *)calendarDate;
> -#pragma clang diagnostic pop
> +ALLOW_DEPRECATED_DECLARATIONS_END
>  #endif

We’ll need to omit this change because it’s in a public header that is part of macOS and iOS API and the content of such headers can’t depend on internal WebKit headers like Compiler.h.

I tried to find other instances of this and did not spot any.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180912/27d771d0/attachment-0001.html>


More information about the webkit-unassigned mailing list