[Webkit-unassigned] [Bug 188174] [WinCairo] Search terms are not saved for <input type="search">

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 09:56:32 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=188174

--- Comment #26 from Stephan Szabo <stephan.szabo at sony.com> ---
(In reply to Stephan Szabo from comment #25)
> (In reply to Fujii Hironori from comment #23)
> > Comment on attachment 352647 [details]
> > Save windows search inputs to sqlite db
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=352647&action=review
> 
> Just updating for most of these, but a few comments.
> 
> > > Source/WebCore/platform/win/SearchPopupMenuWin.cpp:25
> > > +#include <WebCore/FileSystem.h>
> > 
> > Do you use <WebCore/FileSystem.h> in this file?
> 
> Yes, I'm using pathByAppendingComponent and
> localUserSpecificStorageDirectory to generate the database file location.

Sorry, looked back now and had misremembered that I moved the file location out to the DB cpp as well. Will kill that too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181018/3b04b691/attachment.html>


More information about the webkit-unassigned mailing list