[Webkit-unassigned] [Bug 190440] WebKit Inspector: Expose Server Timing Response Headers in Network Tab

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190440

--- Comment #13 from Joseph Pecoraro <joepeck at webkit.org> ---
(In reply to cvazac from comment #12)
> Comment on attachment 352052 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=352052&action=review
> 
> >> Source/WebInspectorUI/UserInterface/Models/ServerTimingEntry.js:135
> >> +                }
> > 
> > It could be that this is a new parameter we don't know about yet, but I like that this code is trying to be future proof/compatible. Also the Function.prototype.call is unnecessary here since we don't use `this`. How about:
> > 
> >     if (parseParameter)
> >         parseParameter(entry, paramValue);
> >     else
> >         console.warn("Unknown Server-Timing parameter:", paramName, paramValue)
> 
> AKAICT, `console.warn`s from here don't make it to the actual browser
> console, only to the command line. Is that what you want?

Yep that is what we want. The web content is not necessarily in error, it may be making use of a feature the frontend is not yet aware of. The console.warn can go to the system console or a inspector², which will be great because those of us developing on it might see it and then decide to add support for a possibly new Server-Timing feature.

It may also be possible that we could turn this into a warning indicator on the Server-Timing row in the popover. That could have a tooltip or some description that says:

    ⚠️ Unknown Parameter: 'dur'

Which would be useful to the developer to show they mis-typed 'dur' as 'duration' and that is why it is not exposed in the tools.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181012/c38613f4/attachment.html>