[Webkit-unassigned] [Bug 190440] WebKit Inspector: Expose Server Timing Response Headers in Network Tab

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 11 19:11:09 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=190440

--- Comment #12 from cvazac at gmail.com ---
Comment on attachment 352052
  --> https://bugs.webkit.org/attachment.cgi?id=352052
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352052&action=review

>> Source/WebInspectorUI/UserInterface/Models/ServerTimingEntry.js:135
>> +                }
> 
> It could be that this is a new parameter we don't know about yet, but I like that this code is trying to be future proof/compatible. Also the Function.prototype.call is unnecessary here since we don't use `this`. How about:
> 
>     if (parseParameter)
>         parseParameter(entry, paramValue);
>     else
>         console.warn("Unknown Server-Timing parameter:", paramName, paramValue)

AKAICT, `console.warn`s from here don't make it to the actual browser console, only to the command line. Is that what you want?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181012/45128c36/attachment.html>


More information about the webkit-unassigned mailing list