[Webkit-unassigned] [Bug 192197] Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192197

--- Comment #6 from Jiewen Tan <jiewen_tan at apple.com> ---
(In reply to Don Olmstead from comment #0)
> Its really odd on the CMake side that there is ENABLE_WEB_CRYPTO and
> ENABLE_SUBTLE_CRYPTO. ENABLE_SUBTLE_CRYPTO seems to be pretty old and maybe
> its time to just change it to ENABLE_WEB_CRYPTO since that better describes
> things.

Thanks for making this patch. However, I want to point it out the reason why this macro is named ENABLE_SUBTLE_CRYPTO instead of ENABLE_WEB_CRYPTO. Web Crypto API consists more than the SubtleCrypto interface. It means the whole Crypto interface: https://www.w3.org/TR/WebCryptoAPI/#crypto-interface. There is no flags for the crypto interface. Without the SubtleCrypto interface, there is the getRandomValues function. Even though SubtleCrypto interface is the bone and meat of Web Crypto API, it still feels semantically wrong to guard SubtleCrypto with ENABLE_WEB_CRYPTO.

Maybe it would be better to rename ENABLE_WEB_CRYPTO to ENABLE_SUBTLE_CRYPTO. From the Crypto class, I believe the crypto interface is enabled by default for all ports? Just the SubtleCrypto interface is platform dependent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181130/8c0f68f1/attachment.html>