[Webkit-unassigned] [Bug 192197] Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 30 11:00:56 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=192197

--- Comment #5 from Don Olmstead <don.olmstead at sony.com> ---
(In reply to Michael Catanzaro from comment #4)
> Comment on attachment 356087 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356087&action=review
> 
> This looks good to be, just needs approval by Jiewen.
> 
> > Tools/Scripts/webkitperl/FeatureList.pm:-350
> > -    { option => "subtle-crypto", desc => "Toggle WebCrypto Subtle-Crypto support",
> > -      define => "ENABLE_SUBTLE_CRYPTO", value => \$subtleCrypto },
> > -
> 
> Alternatively you could rename it to web-crypto so it's still possible to
> disable with build-webkit.

I have some stuff locally where I'm going through and syncing up the perl script and the cmake side. A syncing of xcode features as well will either be in that or in a subsequent patch.

The feature flag stuff is wildly out of date.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181130/192e7b05/attachment.html>


More information about the webkit-unassigned mailing list