[Webkit-unassigned] [Bug 191906] [WPE] Use new view state API from libwpe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191906

--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #6) 
> It's public C API. It's not used inside WebKit itself, but used by
> applications. I agree we can just remove it, but once we bump the libwpe
> requirement.

No it's not. That header is not installed, and the symbols are not exported, so it's impossible for applications to use it. I know it's still available in the downstream port, but this is upstream.

> wpe backend was renamed as libwpe, is the same thing. I find it weird the
> lib prefix, the same way there's no LIBGTK_CHECK_VERSION nor
> LIBSOUP_CHECK_VERSION. The prefix used in all public APIs in libwpe is wpe,
> not libwpe.

So then rename it to WPE_CHECK_VERSION. WPE_BACKEND_CHECK_VERSION is too legacy, too confusing. I know it requires another libwpe API version bump, but the cost of that is very low right now. It will only get harder in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181127/0fc39398/attachment.html>